fix(settings): Hide forbidden UI elements for group managers#47589
Merged
fix(settings): Hide forbidden UI elements for group managers#47589
Conversation
susnux
added
bug
3. to review
susnux
requested review from
a team,
Pytal,
artonge and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
This comment was marked as resolved.
This comment was marked as resolved.
kesselb
approved these changes
Aug 30, 2024
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
Thank you
It fixes the issues I reported 🙏
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
There you go #47642 |
This comment was marked as resolved.
This comment was marked as resolved.
susnux
changed the title
Pytal
approved these changes
Aug 30, 2024
1. The "recent" accounts API only works for admin and delegated admin -> hide for line managers 2. Line managers can not create new groups -> Hide the UI to add a new group for them 3. Accounts created by line managers require one of the groups, which is managed by the line manager, assigned. So if the line manager only manageres a single group, we should preselect that group. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/user-settings-admin
branch
from
8d53984 to
9a8b3de
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47589/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a8b3de2 380b92c0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47589/stable29Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..558fbcd
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47589/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a8b3de2 380b92c0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47589/stable30Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..558fbcd
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
4 tasks
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist