Conversation
nickvergessen
commented
Aug 27, 2024
- ci: Run things we only run on 1 PHP version on the preinstalled 8.1 which installs ~2m faster
- ci: Don't run things normally and with coverage flag on the same configuration
…hich installs ~2m faster Signed-off-by: Joas Schilling <coding@schilljs.com>
…iguration Signed-off-by: Joas Schilling <coding@schilljs.com>
susnux
left a comment
There was a problem hiding this comment.
looks good to me, hope github images move to 24.04 soon :)
| matrix: | ||
| php-versions: ['8.1', '8.2', '8.3'] | ||
| php-versions: ['8.1', '8.2'] | ||
| include: | ||
| - php-versions: '8.3' | ||
| coverage: true |
There was a problem hiding this comment.
Not sure whether the include will not add back 8.3?
Also, would prefer 8.1,8.3 over 8.1,8.2.
There was a problem hiding this comment.
I misunderstood how include works, according to the description of the PR 🤔
There was a problem hiding this comment.
This change here will result in:
- PHP 8.1 coverage ❌
- PHP 8.2 coverage ❌
- PHP 8.3 coverage ✅
There was a problem hiding this comment.
Not sure whether the include will not add back 8.3?
It will and that's exactly the fix. We ran 8.3 (and in other cases 8.2) twice. Once with the coverage flag and once without. But the only difference is whether we generate and upload the report, so we can remove the 8.3 run that is duplicated by the run that also uploads the coverage report
|
Question: why don't use https://github.com/shivammathur/setup-php?tab=readme-ov-file#github-hosted-runners |
Because we use self-hosted runners ;) |
|
/backport to stable30 |