feat: Delegate is-encrypted handling to the e2ee app#47495
Merged
Conversation
ae9c61e to
6426b78
Compare
Contributor
Author
|
/backport to stable30 |
876c7c6 to
4097250
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
4097250 to
ac1d8cd
Compare
come-nc
approved these changes
Aug 27, 2024
Contributor
|
Wait, but FileInfo::isEncrypted is used for SSE and not E2EE, no? |
Contributor
Author
Not sure that I get the concern, but in this case, |
sorbaugh
approved these changes
Aug 27, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The is-encrypted property is signaling the E2EE status, not the SSE one. So it does not make sense to keep it in the server repo.