Update to coding-standard 1.2.3

[kesselb]

• Resolves: unblock dependabot update for coding-standard 1.2.3

Summary

TODO

• Update OpenApi definitions
• Make Psalm happy
• Add SPDX for .git-blame-ignore-revs
• Update check for expected files
• Ping release team to ignore .git-blame-ignore-revs

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[github-advanced-security]

Psalm found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[kesselb]

Error: apps/files_versions/appinfo/routes.php:22:1: InvalidScope: Use of $this in non-class context (see https://psalm.dev/013)

False positive (because the file is included). It's popping up now because the /** @var $this \OCP\Route\IRouter */ (invalid) was changed to /** @var \OCP\Route\IRouter $this */ (valid). That needs an psalm baseline update.

Error: lib/private/Route/Router.php:177:7: NoInterfaceProperties: Interfaces cannot have properties (see https://psalm.dev/028)
Error: lib/private/Route/Router.php:180:4: NoInterfaceProperties: Interfaces cannot have properties (see https://psalm.dev/028)
Error: lib/private/Route/Router.php:182:3: NoInterfaceProperties: Interfaces cannot have properties (see https://psalm.dev/028)

I agree with Psalm the code is highly confusing.

[susnux]

ERROR: There were 1 additional files:
.git-blame-ignore-revs
ERROR: Please remove or add those files again or inform the release team about those now files to be included or excluded from the release tar ball.

Should be excluded from release tar ball, no?

[nickvergessen]

yes should be removed on packaging

[st3iny]

Looks good!

[st3iny]

TIL!

[kesselb]

Error: apps/files_versions/appinfo/routes.php:22:1: InvalidScope: Use of $this in non-class context (see https://psalm.dev/013)
Error: lib/private/Route/Router.php:177:7: NoInterfaceProperties: Interfaces cannot have properties (see https://psalm.dev/028)
Error: lib/private/Route/Router.php:180:4: NoInterfaceProperties: Interfaces cannot have properties (see https://psalm.dev/028)
Error: lib/private/Route/Router.php:182:3: NoInterfaceProperties: Interfaces cannot have properties (see https://psalm.dev/028)

The above errors were fixed by changing @var $this \OCP\Route\IRouter to @var $this \OC\Route\Router in core/routes.php.

server/lib/private/Route/Router.php

Lines 166 to 182 in 1cc6b35

	if (!isset($this->loadedApps['core'])) {
	$this->loadedApps['core'] = true;
	$this->useCollection('root');
	$this->setupRoutes($this->getAttributeRoutes('core'), 'core');
	require_once __DIR__ . '/../../../core/routes.php';
	// Also add the OCS collection
	$collection = $this->getCollection('root.ocs');
	$collection->addPrefix('/ocsapp');
	$this->root->addCollection($collection);
	}
	if ($this->loaded) {
	$collection = $this->getCollection('ocs');
	$collection->addPrefix('/ocs');
	$this->root->addCollection($collection);
	}
	$this->eventLogger->end('route:load:' . $requestedApp);

Psalm resolves the require_once call and assumes, because of the phpdoc annotation, the the class is now IRouter instead of Router and shows a warning that the interface does not have loaded, etc..

[kesselb]

Cypress is having a good day 🥳 🙌