fix(files_versions): Migrate version name dialog from NcModal to NcDialog#47407
Merged
AndyScherzinger merged 2 commits intomasterfrom Aug 22, 2024
Merged
fix(files_versions): Migrate version name dialog from NcModal to NcDialog#47407AndyScherzinger merged 2 commits intomasterfrom
AndyScherzinger merged 2 commits intomasterfrom
Conversation
susnux
added
bug
design
susnux
requested review from
a team,
artonge,
nfebe and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable30 |
Member
|
From a UX perspective, if the version isn't a named version yet - than the re-destructive action button of removing the version name seem misleading. |
artonge
approved these changes
Aug 22, 2024
artonge
reviewed
Aug 22, 2024
Contributor
Author
Makes sense, adjusted: Bildschirmaufnahme_20240822_135654.webm |
susnux
force-pushed
the
fix/version-name-dialog
branch
from
72546ad to
0f97593
Compare
AndyScherzinger
approved these changes
Aug 22, 2024
…alog * Resolves nextcloud/viewer#2390 Make the version name dialog a real dialog instead of a modal. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
AndyScherzinger
force-pushed
the
fix/version-name-dialog
branch
from
0f97593 to
351dd6d
Compare
Member
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the version name dialog a real dialog instead of a modal.
Screen recording (with this PR)
Bildschirmaufnahme_20240822_013252.webm
Checklist