fix: expand select and group by for calendar reminder backend#47399
Merged
fix: expand select and group by for calendar reminder backend#47399
Conversation
Contributor
|
|
4 tasks
Member
|
/backport to stable30 |
solracsf
approved these changes
Sep 15, 2024
Member
|
Contributor
|
This change fails for me with share notifications |
f00a43b to
433bf0d
Compare
ChristophWurst
approved these changes
Sep 18, 2024
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Tested with ONLY_FULL_GROUP_BY on in mariadb. Master fails, this works
👍
Contributor
Author
Other tests are failing now, after rebase |
433bf0d to
8443b63
Compare
Member
|
I've previously submitted a, perhaps, less error-prone PR here (closed because this one was older) : #47996 |
8 tasks
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
8443b63 to
ab3a239
Compare
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist