fix(build): Allow update-apps.sh script to work with non-master branches

[provokateurin]

Summary

The script only worked for apps which use master as their main branch.
This change also makes the script easier to read and also catch errors properly.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

Fails with sh:

$ sh build/update-apps.sh
build/update-apps.sh: 18: set: Illegal option -o pipefail

Fails with french locale:

$ bash build/update-apps.sh

activity
fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths

(because git remote show origin does not contain HEAD branch but a french translation)

[provokateurin]

Fails with sh:

Expected to fail, the shebang clearly says it needs bash.

(because git remote show origin does not contain HEAD branch but a french translation)

Ugh I didn't know and think about that. Not sure how to make that work. I tried a few alternatives, but none of them worked for me at all.

[provokateurin]

For the later we could do a stupid git checkout master || git checkout main. If both fail then the whole script will fail as expected.

[susnux]

Ugh I didn't know and think about that. Not sure how to make that work. I tried a few alternatives, but none of them worked for me at all.

I think in that script just export LANG=C in the beginning should be enough (and should not conflict as long as you do not source it)

[provokateurin]

@come-nc can you try that and if it works make a PR?

[provokateurin]

and should not conflict as long as you do not source it

Instead of using export the env variable could just be applied to the git command that is problematic.

[susnux]

Instead of using export the env variable could just be applied to the git command that is problematic.

Sure this also works :)
I just export to have a consistent scripting env. The env is not leaking into your personal shell session (as long as you do not source it, but why should you? 😅 )

[provokateurin]

Yeah it would be weird to do that, but you mentioned it so we can also just prevent it :D