Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
come-nc,
danxuliu,
provokateurin and
yemkareems
and removed request for
a team
sorbaugh
approved these changes
Aug 20, 2024
skjnldsv
approved these changes
Aug 20, 2024
danxuliu
approved these changes
Aug 20, 2024
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Tested (see #47044 (comment)) and works 👍
artonge
reviewed
Aug 20, 2024
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
What advantage does it bring compared to asking the mount manager? Beside removing one line of code.
come-nc
approved these changes
Aug 20, 2024
Contributor
|
/backport to stable29 |
Contributor
|
/backport to stable28 |
Member
|
/backport to stable30 |
This comment was marked as resolved.
This comment was marked as resolved.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No matter how much I find storages knowing their own mountpoint wrong from ideological level. In practice this info is needed in various places so might as well create a more universal solution for it.