fix: Access node owner by top level owner property#47287
Merged
Conversation
Contributor
Author
|
/backport to stable30 |
Pytal
approved these changes
Aug 16, 2024
skjnldsv
approved these changes
Aug 17, 2024
|
|
||
| // Group shares | ||
| if (shareTypes.includes(ShareType.Grup) | ||
| if (shareTypes.includes(ShareType.Group) |
Member
|
Contributor
Author
Happens because Cypress does not compile the sources before testing -> So it fails like it does on master. As soon as we compile it will work here. (No idea why the compile step was removed from cypress?) |
aeb6317 to
eb89925
Compare
Contributor
Author
|
/compile |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
d26e288 to
fa11a67
Compare
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As suggested by @skjnldsv in the previous PR we should not use
owner-iddirectly but just use the top levelownerattribute (which will be set to owner-id anyways by default).This fixes the mentioned issue, moreover I added some tests for the inline status action and a regression test for this bug.
(We nevertheless should fix the wrong type of the
owner-idattribute indavResultToNodeand cast it to string, but we can do so later in@nextcloud/files)Checklist