ensure theming app is loaded when showing an error page#4719
Merged
LukasReschke merged 1 commit intomasterfrom May 8, 2017
Merged
ensure theming app is loaded when showing an error page#4719LukasReschke merged 1 commit intomasterfrom
LukasReschke merged 1 commit intomasterfrom
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Member
|
Let's hope the theming page never has an error 🙈 Could you add a try catch around this, just in case? |
Member
Author
|
If the theming app triggers an error page |
LukasReschke
approved these changes
May 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent un-themed error pages when an error is triggered before the theming app can load naturally.
You can reproduce the problem with the guests app and trying to access an app guests do not have access to as guest