feat(sharebymail): improve share email format#46985
Merged
Conversation
e750265 to
96b2d57
Compare
Contributor
Member
Author
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
Merged
nimishavijay
approved these changes
Aug 5, 2024
Member
nimishavijay
left a comment
There was a problem hiding this comment.
Super nice! Very cool that the buttons are rounded now :)
All looks good, only small change I would suggest is to remove the message in gray at the bottom "X shared Y with you. Click the button below to open it." as it seems redundant now :)
Approving to not block
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
eb5bea7 to
879d248
Compare
sorbaugh
approved these changes
Aug 6, 2024
susnux
approved these changes
Aug 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



As discussed:
»and«Fix #15680
cc @jancborchardt @nimishavijay @marcoambrosini