perf(files): Cache getContents function used for uploader#46966
Merged
perf(files): Cache getContents function used for uploader#46966
getContents function used for uploader#46966Conversation
susnux
added
3. to review
skjnldsv
approved these changes
Aug 1, 2024
Merged
Pytal
approved these changes
Aug 13, 2024
Instead of trigger a PROPFIND for every new-menu entry clicks, or conflict handling of uploads, we can just use the cached content from the file store. If we do not have any cache entry we fetch new, but otherwise this is not needed. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/cache-uploader-get-content-function
branch
from
77d834e to
c60e59c
Compare
skjnldsv
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of trigger a PROPFIND for every new-menu entry clicks, or conflict handling of uploads, we can just use the cached content from the file store. If we do not have any cache entry we fetch new, but otherwise this is not needed.
Checklist