fix(files): Correctly validate new node name#46767
Merged
Conversation
Contributor
Author
|
/backport to stable29 |
nfebe
approved these changes
Jul 26, 2024
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Except for synonym addition, lgtm
skjnldsv
reviewed
Jul 26, 2024
| triggerActionForFile('file.txt', 'rename') | ||
|
|
||
| getRowForFile('file.txt') | ||
| .findByRole('textbox', { name: 'Filename' }) |
skjnldsv
approved these changes
Jul 26, 2024
Member
|
/compile rebase-amend / |
* Resolves #45409 This includes two fixes: 1. The name in the "new node" dialog is correctly selected (e.g. `file.txt` only `file` is selected by default), to allow quick naming 2. `@nextcloud/files` functions for filename validation are used, this allows to use new Nextcloud 30 capabilities (e.g. reserved names) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/files-new-file-node
branch
from
cfa878e to
dd88fa0
Compare
2 tasks
Merged
Member
|
Hi @susnux |
Contributor
Author
|
@Jerome-Herbinet yes please open a ticket :) |
8 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This includes two fixes:
file.txtonlyfileis selected by default), to allow quick naming@nextcloud/filesfunctions for filename validation are used, this allows to use new Nextcloud 30 capabilities (e.g. reserved names)Screen recording
Bildschirmaufnahme_20240725_215605.webm
Checklist