fix(settings/SetupChecks): Don't follow redirects#46449
Closed
marcelklehr wants to merge 1 commit intomasterfrom
Closed
fix(settings/SetupChecks): Don't follow redirects#46449marcelklehr wants to merge 1 commit intomasterfrom
marcelklehr wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
I think not following is a bad idea as there could be a redirect that still resolves to the data directory. |
Contributor
|
I agree with Ferdinand it makes sense to follow redirects, at least for some tests. Maybe we should add content to |
4 tasks
Contributor
|
See #46456 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In some cases the reverse proxy config redirects to login when accessing unknown URLs like .ocdata. Login, however, returns a HTTP 200, which is taken to be a failure by the datadirectory protection setup check.
Checklist