feat(occ): Add support for iterable in Base and use it in group:list and user:list#46356
Merged
feat(occ): Add support for iterable in Base and use it in group:list and user:list#46356
Conversation
come-nc
requested review from
ArtificialOwl,
sorbaugh and
yemkareems
and removed request for
a team
come-nc
changed the title
Merged
yemkareems
approved these changes
Aug 6, 2024
Altahrim
approved these changes
Aug 6, 2024
…and user:list Signed-off-by: Côme Chilliet <[email protected]>
iterator_to_array cannot take an array parameter prior to 8.2 Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
enh/use-generator-for-group-list
branch
from
61763bf to
bb94da6
Compare
Signed-off-by: Côme Chilliet <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for iterable in
OC\Core\Command\Base::writeArrayInOutputFormatwhen output format is not json and takes advantage of it to makegroup:listoutput more fluid.For
user:listthe impact is less noticable because the user array is prepared first and that takes up most of the time.Checklist