Conversation
icewind1991
requested review from
come-nc,
juliusknorr,
miaulalala and
nickvergessen
icewind1991
force-pushed
the
remove-chunking-v1
branch
2 times, most recently
from
55219c1 to
f0b242e
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
remove-chunking-v1
branch
from
f0b242e to
957a00b
Compare
juliusknorr
approved these changes
Jun 24, 2024
Merged
|
thanks a lot, it really makes the project easier to dive in 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally removed in #36589 but that got reverted after other changes from that PR were causing issues.
I've split this off to make any future attempt at removing the "cache gc"/"setup filesystem on every basic auth" easier to consider in the future.