[stable29] fix(settings): define a 'heartbeat' route, so SecurityHeaders can handle redirected root#45956
Merged
provokateurin merged 3 commits intostable29from Jul 10, 2024
Merged
Conversation
provokateurin
approved these changes
Jun 18, 2024
come-nc
approved these changes
Jun 20, 2024
Merged
MichaIng
approved these changes
Jun 30, 2024
8 tasks
Merged
d5cd9c2 to
caae551
Compare
Contributor
|
Contributor
|
Pushed 76efdb0 to fix the failing test. The router uses include_once to load route definitions from the apps. First include_once for apps/files/appinfo/routes.php returns the expected array. Second include_once returns true, because the file was already included. To workaround the tests must run in a separate process. I have no idea why the test is not failing on master. |
Contributor
That does not seem to work
The test is not failing on master because the app manager instance is mocked, the app path is null and the routing file not even included: #46416 |
76efdb0 to
caae551
Compare
Merged
1 task
fa5a153 to
19dff6d
Compare
…dle redirected root Signed-off-by: Steve Mokris <steve@kosada.com>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
de1f1a8 to
a554ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #45228