[stable29] fix(files): handling numbered type owner name & id#45764
[stable29] fix(files): handling numbered type owner name & id#45764skjnldsv merged 1 commit intonextcloud:stable29from sanskar-soni-9:fix/numbered-owner-name-and-id
Conversation
|
/backport to stable28 |
susnux
left a comment
There was a problem hiding this comment.
Fixed on master but on stable29 and stable28 we need this.
Thank you.
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
| 'owner-id': owner, | ||
| 'owner-display-name': String(props['owner-display-name']), |
There was a problem hiding this comment.
I see we made some mistake and used it in a few locations, I would suggest we fix the usage instead of providing owner-id as extra attributes 🤔
owner-display-name on the other hand is fine I think
There was a problem hiding this comment.
Well, we fixed it for NC30 and above, I think we can merge for older branches as a safety measure.
I'll create a PR for master 🚀
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable28 (force recreate) |
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/45764/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d78d468b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45764/stable28Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45764/stable28."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Handles numbered 'owner-id' and 'owner-display-name'
Before
After
Checklist