fix(setupChecks): Update Transactional File Locking instructions#45471
Merged
icewind1991 merged 1 commit intomasterfrom Sep 19, 2024
Merged
fix(setupChecks): Update Transactional File Locking instructions#45471icewind1991 merged 1 commit intomasterfrom
icewind1991 merged 1 commit intomasterfrom
Conversation
joshtrichards
added
enhancement
3. to review
joshtrichards
requested review from
Altahrim,
ArtificialOwl,
icewind1991,
sorbaugh and
yemkareems
joshtrichards
force-pushed
the
fix-setupcheck-filelocking
branch
2 times, most recently
from
4a145af to
4fdeae4
Compare
joshtrichards
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Merged
icewind1991
approved these changes
Sep 16, 2024
sorbaugh
approved these changes
Sep 17, 2024
icewind1991
force-pushed
the
fix-setupcheck-filelocking
branch
from
4fdeae4 to
98a5829
Compare
…upported Signed-off-by: Josh Richards <[email protected]>
icewind1991
force-pushed
the
fix-setupcheck-filelocking
branch
from
98a5829 to
e019eae
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
filelocking.enabledtoggle is no longer relevant today since TFL is now on by default and is no longer an experimental feature (hasn't been for nearly a decade). There is no good reason to disable it. The toggle only exists to be able to enable it, when it was still experimental. It's also been removed from the docs.This PR:
Complements #45330 and nextcloud/documentation#11848 (does not depend on either)
TODO
Checklist