fix(login): Disable login button when already logging in#45352
Merged
juliusknorr merged 3 commits intomasterfrom Jun 6, 2024
Merged
fix(login): Disable login button when already logging in#45352juliusknorr merged 3 commits intomasterfrom
juliusknorr merged 3 commits intomasterfrom
Conversation
ChristophWurst
approved these changes
May 16, 2024
Member
|
To prevent double submit through enter we could adjust LoginForm.vue and ignore form submit while loading=true as well. Apparently this would be possible with a disabled field set: https://stackoverflow.com/questions/3507958/how-can-i-make-an-entire-html-form-readonly |
Contributor
Author
|
Right, I didn’t think of enter. Let me adjust the PR |
Contributor
Author
I tried that, but then I am unable to login in any way (it always ends up in a temporary error). Therefore I prevented another submit of the form, as we already have a submit handler. |
ChristophWurst
approved these changes
May 16, 2024
provokateurin
approved these changes
Jun 4, 2024
juliusknorr
approved these changes
Jun 6, 2024
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
53f09bd to
f6e6d7a
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes "State token does not match" in some cases (e.g. double click on the login button)
How to reproduce:
Before
After
Checklist