Merged
Conversation
skjnldsv
reviewed
May 14, 2024
susnux
force-pushed
the
feat/upload-folders
branch
3 times, most recently
from
36b5ec4 to
910301f
Compare
susnux
changed the title
susnux
added
3. to review
artonge
reviewed
Jun 17, 2024
| class="files-list__header-upload-button" | ||
| :content="getContent" | ||
| :destination="currentFolder" | ||
| :forbidden-characters="forbiddenCharacters" |
Contributor
There was a problem hiding this comment.
Shouldn't this be built in the lib?
In Photos we are using the uploader, it would be nice to have this by default
Contributor
Author
There was a problem hiding this comment.
Yes the forbidden-characters can be replaced by nextcloud-files version.
Contributor
Author
There was a problem hiding this comment.
We can do so in a new uploader version :)
artonge
approved these changes
Jun 17, 2024
susnux
force-pushed
the
feat/upload-folders
branch
4 times, most recently
from
2c162ce to
be6a1f4
Compare
susnux
force-pushed
the
feat/upload-folders
branch
2 times, most recently
from
079fd2d to
0a714ca
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/upload-folders
branch
from
0a714ca to
7590c76
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for uploading folders using the "new" menu.
Checklist