perf(db): Sort data for IN before chunking#45058
Merged
ChristophWurst merged 1 commit intomasterfrom May 7, 2024
Merged
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Altahrim
approved these changes
Apr 26, 2024
Collaborator
Altahrim
left a comment
There was a problem hiding this comment.
I didn't knew the trick to sort items. The other one is to use smaller chunks.
nickvergessen
approved these changes
Apr 29, 2024
Member
Could, as that is also the direction where we are coming from |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
This was referenced May 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nextcloud sends chunks of
DELETE FROM oc_filecache WHERE parentid IN (....long list...)and sometimes MariaDB does not seem to pick up the index. Apparently this may happen when the query analyzer thinks it's cheaper to scan the table than to traverse the index. If we put the data of the chunks closer together, we can hopefully convince the db that the index is the faster choice.@juliushaertl @nickvergessen as it was suggested to us.
I don't know how to trigger this code with lots of data so this is more or less untested.
Checklist