fix(caldav): When message is a reply compare the message sender not the recipient#44893
fix(caldav): When message is a reply compare the message sender not the recipient#44893
Conversation
SebastianKrupinski
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
solracsf
changed the title
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Tested & works
Could you please extend \OCA\DAV\Tests\unit\CalDAV\Schedule\IMipPluginTest for three tests that cover the three possible paths of \OCA\DAV\CalDAV\Schedule\IMipService::getCurrentAttendee? 1. Reply, 2. invite, 3. no match.
| } | ||
| elseif (strcasecmp($attendee->getValue(), $iTipMessage->recipient) === 0) { |
There was a problem hiding this comment.
| } | |
| elseif (strcasecmp($attendee->getValue(), $iTipMessage->recipient) === 0) { | |
| } elseif (strcasecmp($attendee->getValue(), $iTipMessage->recipient) === 0) { |
|
/backport to stable29 |
|
/backport to stable28 |
I'm sorry, I mixed up the classes. We want to unit test Move the tests please |
|
/backport to stable27 |
…he recipient Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com> Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
SebastianKrupinski
force-pushed
the
fix/issue-43115
branch
from
96d9b4e to
d7eb509
Compare
5 participants
Summary
When message is a reply compare the message sender not the recipient.