build(deps): bump nextcloud/coding-standard from 1.1.1 to 1.2.1 in /vendor-bin/cs-fixer#44534
Merged
dependabot[bot] merged 4 commits intomasterfrom Apr 2, 2024
Conversation
nextcloud-command
approved these changes
Mar 28, 2024
Contributor
nextcloud-command
left a comment
There was a problem hiding this comment.
@dependabot merge
Contributor
Author
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
come-nc
approved these changes
Mar 28, 2024
Contributor
|
| $used = 0; | ||
| array_walk($codes, function (BackupCode $code) use (&$used) { | ||
| if (1 === (int)$code->getUsed()) { | ||
| if ((int)$code->getUsed() === 1) { |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType
|
|
||
| foreach ($dbCodes as $dbCode) { | ||
| if (0 === (int)$dbCode->getUsed() && $this->hasher->verify($code, $dbCode->getCode())) { | ||
| if ((int)$dbCode->getUsed() === 0 && $this->hasher->verify($code, $dbCode->getCode())) { |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType
| $this->folder = $folder; | ||
|
|
||
| if (!is_dir($this->folder) && false === @mkdir($this->folder, 0777, true) && !is_dir($this->folder)) { | ||
| if (!is_dir($this->folder) && @mkdir($this->folder, 0777, true) === false && !is_dir($this->folder)) { |
Check failure
Code scanning / Psalm
TaintedFile
| } | ||
|
|
||
| if (false === file_put_contents($file, serialize($data), 0, $context)) { | ||
| if (file_put_contents($file, serialize($data), 0, $context) === false) { |
Check failure
Code scanning / Psalm
TaintedFile
nickvergessen
approved these changes
Mar 28, 2024
0fd7280 to
d221b98
Compare
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.1.1 to 1.2.1. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](nextcloud/coding-standard@v1.1.1...v1.2.1) --- updated-dependencies: - dependency-name: nextcloud/coding-standard dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
d221b98 to
81319e7
Compare
Contributor
|
/backport to stable29 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps nextcloud/coding-standard from 1.1.1 to 1.2.1.
Release notes
Sourced from nextcloud/coding-standard's releases.
Changelog
Sourced from nextcloud/coding-standard's changelog.
Commits
cf5f18dMerge pull request #16 from nextcloud/nickvergessen-patch-135fd40efix(docs): Update old file name in readme51cf509fix: Removefully_qualified_strict_typesagain424cdd9Merge pull request #15 from nextcloud/enh/extend-coding-standardc178f60chore: Add missing entries to changeloga60ff69enh: Force short syntax for list as well7180117enh: Remove leading slash in use statements2fce407enh: Remove namespace from class FQDN if there is a use statement1dedda4enh: Set type as nullable when default value is null (needed for PHP 8.4)d9cd7a3enh: Forbid yoda style comparisonDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)