[stable27] fix(share): Send correct share attributes upon share creation#44499
Merged
[stable27] fix(share): Send correct share attributes upon share creation#44499
Conversation
backportbot
bot
added
3. to review
nfebe
force-pushed
the
backport/44484/stable27
branch
from
24f0d3e to
2ac47d0
Compare
nfebe
approved these changes
Mar 27, 2024
Merged
emoral435
reviewed
Mar 29, 2024
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
PR seems to not be complete
Contributor
Hi @emoral435 Can you be more specific? This is a backport. |
Contributor
|
It differs from the original, the json decode of the attributes is missing. Is this expected @fenn-cs ? |
nfebe
force-pushed
the
backport/44484/stable27
branch
from
2ac47d0 to
09e428a
Compare
Contributor
|
Thanks @susnux and @emoral435, line in. |
Contributor
|
/compile / |
nfebe
force-pushed
the
backport/44484/stable27
branch
from
1ab8750 to
f179349
Compare
Contributor
|
/compile / |
emoral435
approved these changes
Apr 1, 2024
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
LGMT now! Sorry for the confusion with my wording 😔
emoral435
force-pushed
the
backport/44484/stable27
branch
from
58d0bb3 to
657a9b7
Compare
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe
force-pushed
the
backport/44484/stable27
branch
from
657a9b7 to
58db30d
Compare
Contributor
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Member
|
Seems a force merge is needed here (CI failure is unrelated). |
solracsf
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #44484
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.