refactor: remove non-shallow getSharesInFolder#44460
Merged
icewind1991 merged 1 commit intomasterfrom May 17, 2024
Merged
Conversation
icewind1991
requested review from
a team,
ArtificialOwl,
artonge,
come-nc,
nfebe and
sorbaugh
and removed request for
a team
artonge
reviewed
Mar 25, 2024
Merged
come-nc
approved these changes
Mar 28, 2024
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Same question as Louis, but my guess is filtering on node id is enough and checking the storage is redundant?
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
remove-non-shallow-in-folder
branch
from
8f14034 to
ccd5667
Compare
artonge
approved these changes
May 7, 2024
Member
Author
|
Yes, the storage check is redundant with the |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is only used in one spot and makes it a lot more complicated to remove the filecache joins.