feat(command): Print a success message with the add/remove use occ command

[zak39]

Summary

Before

When we add or remove an user from a group. The end-user doesn't know if the command was successful or not.

After

Now, the end-user is informed when he/she adds or removes an user from a group with the occ command.

TODO

• Install your Nextcloud instance
• Create a few users
• Create a few groups
• From the terminal, run the following commands :
  • php occ group:adduser <groupname> <uid>
  • php occ group:remove <groupname> <uid>

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

When we add or remove an user from a group. The end-user doesn't know if the command was successful or not.

They do. The return code is either 0 for success (as usual) and non zero otherwise.

You can even configure your shell to show the exit code visually, or do
php occ group:adduser <groupname> <uid> && echo 'success'

[zak39]

Hi @susnux :)

Yes, I know. But, I think it's not clear to some people.
Whether they are beginner or senior.

My suggestion is to clearly display a success message to confirm that the order is working.

Like the php occ app:enable <appid> command, which shows that the app is enabled.

[tcitworld]

Instead of just success, it could have a proper sentence: User $uid was added/removed to/from group $gid

[zak39]

Instead of just success, it could have a proper sentence: User $uid was added/removed to/from group $gid

Yes, I think it's a good idea ! 👍

Should I wait for the developers Nextcloud or community to approve your suggestion ?

[come-nc]

I agree with @tcitworld, make sure the message is informative.
Also double check that --quiet works as expected and silence your added output, for scripts which would want the old behavior.