fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date#44281
Merged
AndyScherzinger merged 1 commit intomasterfrom Mar 19, 2024
Merged
fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date#44281AndyScherzinger merged 1 commit intomasterfrom
AndyScherzinger merged 1 commit intomasterfrom
Conversation
susnux
added
bug
3. to review
susnux
requested review from
a team,
ArtificialOwl,
artonge and
nfebe
and removed request for
a team
Merged
susnux
force-pushed
the
fix/app-discover-fetcher
branch
2 times, most recently
from
0b3c2e8 to
c9696d3
Compare
artonge
approved these changes
Mar 18, 2024
susnux
force-pushed
the
fix/app-discover-fetcher
branch
from
6d4a3f5 to
220964b
Compare
…o expiry date Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
AndyScherzinger
force-pushed
the
fix/app-discover-fetcher
branch
from
220964b to
bae133b
Compare
4 tasks
Altahrim
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If there is no
expiryDateordateset, then ignore those. Also always include upcoming entries from the API because the result is cached.Checklist