fix: ensure nested mount points are handled in the correct order#44279
Merged
icewind1991 merged 1 commit intomasterfrom Mar 18, 2024
Merged
fix: ensure nested mount points are handled in the correct order#44279icewind1991 merged 1 commit intomasterfrom
icewind1991 merged 1 commit intomasterfrom
Conversation
artonge
approved these changes
Mar 18, 2024
Contributor
artonge
left a comment
There was a problem hiding this comment.
Make sense.
Any idea how they could be in the wrong order in the first place?
Member
Author
Did some more testing and it seems to be just the order the groupfolders were created in. So if you create |
Merged
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
come-nc
approved these changes
Mar 18, 2024
Signed-off-by: Robin Appelman <robin@icewind.nl>
e6ffb23 to
afb589a
Compare
This was referenced Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise etag propagation across nested mountpoints won't behave correctly.
To test:
gf1,gf1/gf2andgf1/gf2/gf3$aand$baround to change the sort order to be intentionally wrongDepth: 1ongf1and ongf1/gf2gf1/gf2differs between the two requests$aand$bbackDepth: 1ongf1and ongf1/gf2gf1/gf2should now be the same between the two requests