fix(files_external): Remove invalid jQuery Tooltip usage#44264
Merged
Conversation
This caused the UI to throw an error causing it to be unusable. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
|
@susnux |
come-nc
approved these changes
Mar 18, 2024
Contributor
come-nc
left a comment
There was a problem hiding this comment.
UI is working again with this PR.
Only problem I’ve spotted: clicking the 3-dot button opens a menu, but clicking it again does not close it, the user have to find a spot in the UI that does nothing and click it, it’s the only way to close this menu.
Contributor
Actually not sure if 28 is impacted or not, @susnux ? |
szaimen
approved these changes
Mar 18, 2024
Contributor
szaimen
left a comment
There was a problem hiding this comment.
tested and seems to work :)
Contributor
Author
No stable 28 was not affected, we only did this for 29 iirc. |
Contributor
Author
Unrelated, those should not cause problems. The 3-dot menu is another issue. I hope to find time to migrate the settings to vue soon 😉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tooltip methods were remove long ago but we removed the "polyfill" (try-catch) so this caused the UI to throw an error causing it to be unusable.
Checklist