fix(files): Adjust dropservice to work with Blink engine#44254
Merged
fix(files): Adjust dropservice to work with Blink engine#44254
Conversation
susnux
requested review from
Pytal,
emoral435 and
szaimen
and removed request for
a team
susnux
force-pushed
the
fix/drop-service-chrome
branch
from
a7855b5 to
e333ced
Compare
Contributor
Author
|
/backport to stable28 |
skjnldsv
approved these changes
Mar 17, 2024
szaimen
approved these changes
Mar 18, 2024
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Tested and works :)
(but didnt review the code)
…edge) The datatransfer items list is cleared on Blink after the first access to an inner prop due to async handling and GC. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/drop-service-chrome
branch
from
e333ced to
f99c580
Compare
2 tasks
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Due to handling of the data transfer object in Blink the datatransfer.items list is cleared when accessing the entries props.
This happens due to GC of async function calls, so to fix this we simply cache the list to keep a reference to the values.
Also added Cypress tests for this behavior.
Checklist