fix(updatenotification): spread the use of new iappconfig#44165
Merged
fix(updatenotification): spread the use of new iappconfig#44165
Conversation
c0f0d85 to
ffa611e
Compare
3ef8856 to
f3fb5ec
Compare
Signed-off-by: Maxence Lange <[email protected]>
f3fb5ec to
519e434
Compare
Altahrim
approved these changes
Mar 13, 2024
susnux
approved these changes
Mar 13, 2024
Closed
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix a regression from #43967 and #43454 where new appconfig's api were used to type values while the old API was still used in some other place
Context
It has been decided that once a config value is set as anything other than
mixed(default type for config value pre-29) it cannot be set back to mixed.Meaning that once
IAppConfig::setValueString()have been called on a config key, any line of code using the old API to set a value for this config key would returns an exception like this one: