fix(files): Adjust sidebar - remove deprecated function calls and add aria label for favorite icon#43988
Merged
fix(files): Adjust sidebar - remove deprecated function calls and add aria label for favorite icon#43988
Conversation
…a-label to favorite icon Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/compile amend |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/files-favorite
branch
from
5086392 to
b2610d3
Compare
JuliaKirschenheuter
approved these changes
Mar 5, 2024
Contributor
JuliaKirschenheuter
left a comment
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
great, thank you!
ShGKme
approved these changes
Mar 5, 2024
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Works and fixes a11y issue.
I've noticed one non-comfortable place in the NcAppSidebar - actions if the next element after header, so reading the page in browse mode, you read:
- File name
- Actions
- Close button
- Favorite, size, date (aka description for the file from 1)
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OC.->@nextcloud/...).aria-labelfor the favorite markerChecklist