feat(oauth2): simple userinfo endpoint#43684
Open
hardviper wants to merge 23 commits intonextcloud:masterfrom
Open
feat(oauth2): simple userinfo endpoint#43684hardviper wants to merge 23 commits intonextcloud:masterfrom
hardviper wants to merge 23 commits intonextcloud:masterfrom
Conversation
e7d19eb to
f5b90e2
Compare
Author
|
@skjnldsv Is there anything else I can add to help you accept this? |
Member
Author
|
@skjnldsv This adds the user_info endpoint, but does not add the discovery. |
Signed-off-by: d.kudrinskiy <[email protected]>
6b373db to
d934c98
Compare
Member
|
There was an issue with the rebase, please fix it |
Signed-off-by: d.kudrinskiy <[email protected]>
Signed-off-by: d.kudrinskiy <[email protected]>
d934c98 to
21a1825
Compare
Author
|
@skjnldsv Ready! I have corrected! I don't understand how these commits got here. |
Signed-off-by: d.kudrinskiy <[email protected]>
ChristophWurst
requested changes
Feb 23, 2024
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
I'm fine with the endpoint. Some instructions for testing would be appreciated.
The name split logic probably doesn't work for all names. If we can I would strongly favor removing it and only exposing the full name.
Merged
Merged
Merged
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Merged
This was referenced Jan 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This solves the oAuth2 authorization issue in openproject when openproject is the client.
Added endpoint that returns a minimum set of user information.
This is very necessary in my openproject integration with nextcloud.
I hope this helps someone else.
Thanks to @jlallana for suggesting this solution in PR #19934.
Checklist
\OCA\OAuth2\Tests\Controller\OauthApiControllerTest