Conversation
Pytal
approved these changes
Feb 16, 2024
Member
|
We can also just fast forward to a new NC/Vue release. This is 29 as alpha state, that happens :) |
Contributor
Author
|
Ah, okay! Truthfully, I was a bit nervous about making the breaking visual change on the developer instance, but the buttons still work, and having to submit the same PR again would be a lot. Closing PR unless otherwise told to open again. |
emoral435
deleted the
revert-43604-enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #43604
We still need to get nextcloud-libraries/nextcloud-vue#5216 merged first before we get the previous PR merged 🥹
Without having the newest NcVue library version, it will introduce a regression as such:
Once the new library gets merged, will add the changes back!