Do not show full storage notification to users with 0 Bytes quota#43544
Closed
jkhradil wants to merge 1 commit intonextcloud:masterfrom
Closed
Do not show full storage notification to users with 0 Bytes quota#43544jkhradil wants to merge 1 commit intonextcloud:masterfrom
jkhradil wants to merge 1 commit intonextcloud:masterfrom
Conversation
skjnldsv
requested review from
a team,
nfebe,
sorbaugh and
susnux
and removed request for
a team
susnux
approved these changes
Feb 13, 2024
Member
|
/compile rebase / |
Member
|
/backport to stable28 |
skjnldsv
added
4. to release
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
no-full-storage-notification-0-quota
branch
from
7d3e563 to
1806b63
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Comment on lines
+91
to
+92
| // Warn the user if the available storage is 0 on page load, except for users with 0 B quota | ||
| if (this.storageStats?.free <= 0 && this.storageStats?.quota != 0) { |
Member
There was a problem hiding this comment.
Suggested change
| // Warn the user if the available storage is 0 on page load, except for users with 0 B quota | |
| if (this.storageStats?.free <= 0 && this.storageStats?.quota != 0) { | |
| // Warn the user if the available storage is 0 on page load, except for users with 0 B or unlimited quota | |
| if (this.storageStats?.free <= 0 && this.storageStats?.quota != 0 && this.storageStats?.quota != -3) { |
I think something like the above can fix #43280 here too at the other end of the quota spectrum (an unlimited one).
When the quota is unlimited, quota should be -3 here e.g. SPACE_UNLIMITED via getStorageInfo() and getUserQuota() et al.
Contributor
There was a problem hiding this comment.
yes, I think this makes sense
Member
There was a problem hiding this comment.
Then let's check for quota greater or equal to 0. That way we also ignore negative quotas
Resolves nextcloud#43535 Signed-off-by: jkhradil <jkhradil@gmail.com>
joshtrichards
force-pushed
the
no-full-storage-notification-0-quota
branch
from
1806b63 to
ffd4f0c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
/compile |
4 tasks
Member
joshtrichards
removed
the
4. to release
hardviper
pushed a commit
to hardviper/server
that referenced
this pull request
Feb 21, 2024
…quotas Fixes nextcloud#43535 Fixes nextcloud#43280 Replaces nextcloud#43544 Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: d.kudrinskiy <hardviper@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not show “Your storage is full, files can not be updated or synced anymore!” notification to users with quota set to 0 Bytes.
Checklist