Conversation
bf68594 to
18a6b62
Compare
dfab91a to
2455381
Compare
bf6cb92 to
2232753
Compare
2455381 to
de5a1cf
Compare
Base automatically changed from
enh/noid/leave-log-early-if-no-crash-reporter
to
master
February 23, 2024 20:56
8117def to
9148d4c
Compare
Member
That's a nice one 😆
That makes sense, but check if some initializing code passes in |
Member
Author
|
Hello Sir ! Hardcoded initialisation in core are fine, i'll remove your code :) |
9148d4c to
b502b8e
Compare
emoral435
approved these changes
Mar 5, 2024
Contributor
emoral435
left a comment
There was a problem hiding this comment.
Good ol' cleaning commit, love to see this 🥳
4ece900 to
2d0a80a
Compare
Merged
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2d0a80a to
618aadd
Compare
Merged
Altahrim
approved these changes
Mar 15, 2024
This was referenced Mar 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small minor syntax update.
I have currently no idea how we can manage this FIXME:
server/lib/private/Log.php
Lines 74 to 77 in b8272ea
It comes from a 9 years old commit e79c255
🫂 @MorrisJobke
2 solutions:
$config