feat: Log large assets that are initially loaded on the frontend#43429
Closed
juliusknorr wants to merge 1 commit intomasterfrom
Closed
feat: Log large assets that are initially loaded on the frontend#43429juliusknorr wants to merge 1 commit intomasterfrom
juliusknorr wants to merge 1 commit intomasterfrom
Conversation
szaimen
reviewed
Feb 7, 2024
juliusknorr
force-pushed
the
feat/log-large-assets
branch
from
58ee47d to
94f77fb
Compare
AndyScherzinger
force-pushed
the
feat/log-large-assets
branch
from
94f77fb to
f1a8347
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
feat/log-large-assets
branch
from
f1a8347 to
ecfbcc6
Compare
Merged
Member
Author
|
Let me close this for now. I feel that those log messages are rather annoying to everyone not working on frontend and likely also not an easy fix for some. Webpack already warns about large assets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the offset, currently we have some reportings by default: