fix(db): remove redundant index in cards#43340
Merged
Conversation
JohannesGGE
added
bug
3. to review
solracsf
reviewed
Feb 5, 2024
|
|
||
| $tableCards = $schema->getTable('cards'); | ||
|
|
||
| if ($tableCards->hasIndex('cards_abid')) { |
Member
There was a problem hiding this comment.
Suggested change
| if ($tableCards->hasIndex('cards_abid')) { | |
| if ($tableCards->hasIndex('cards_abiduri')) && | |
| ($tableCards->hasIndex('cards_abid')) { |
Maybe double check?
5 tasks
JohannesGGE
force-pushed
the
fix/43118/remove-redundant-index
branch
2 times, most recently
from
5a83555 to
c664339
Compare
miaulalala
approved these changes
Feb 14, 2024
ChristophWurst
added
4. to release
ChristophWurst
previously requested changes
Feb 14, 2024
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Comment out the index creation in \OCA\DAV\Migration\Version1004Date20170924124212::changeSchema to avoid creating and dropping the index for new installations
ChristophWurst
added
3. to review
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
JohannesGGE
force-pushed
the
fix/43118/remove-redundant-index
branch
from
c664339 to
631f2b4
Compare
st3iny
approved these changes
Feb 23, 2024
Merged
kesselb
added a commit
that referenced
this pull request
Mar 19, 2024
Follow up for #43340 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove index
cards_abidbecausecards_abidurialready contains the column on the first position.TODO
Checklist