fix(settings): posix_getpwuid can return false which should not be accessed like an array#43334
Merged
fix(settings): posix_getpwuid can return false which should not be accessed like an array#43334
posix_getpwuid can return false which should not be accessed like an array#43334Conversation
susnux
added
bug
3. to review
susnux
requested review from
a team,
Altahrim,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable27 |
Contributor
Author
|
/backport to stable26 |
icewind1991
approved these changes
Feb 9, 2024
Merged
Altahrim
approved these changes
Mar 13, 2024
Altahrim
added
4. to release
…e accessed using array operation Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Altahrim
force-pushed
the
fix/array-access-on-boolean
branch
from
6f5a1d4 to
002fda6
Compare
This was referenced Mar 13, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
fileowneris false or the user can not read/etc/passwd(SELinux etc) thenposix_getpwuidwill fail and returnfalsewhich of cause should not be accessed likefalse['user'].This is one of the errors reported in the log of nextcloud/notifications#2267
Checklist