Closed
Conversation
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Member
Author
|
/backport! to backport/43090/stable28 |
ShGKme
approved these changes
Feb 1, 2024
ShGKme
reviewed
Feb 1, 2024
| // Allow right click to define the position of the menu | ||
| // only if defined | ||
| .app-content[style*="mouse-pos-x"] .v-popper__popper { | ||
| .content[style*="mouse-pos-x"] .v-popper__popper { |
Contributor
There was a problem hiding this comment.
Isn't it the same? Do we need root class here at all?
Suggested change
| .content[style*="mouse-pos-x"] .v-popper__popper { | |
| [style*="mouse-pos-x"] .v-popper__popper { |
Member
Author
There was a problem hiding this comment.
Isn't it far less efficient?
Contributor
There was a problem hiding this comment.
Isn't it far less efficient?
Probably it is
emoral435
reviewed
Feb 1, 2024
Contributor
emoral435
left a comment
There was a problem hiding this comment.
Overall good - however, it seems that firefox has had yet another regression (😓😓):
I remember this being mentioned in a PR before, but I cannot remember for the life of me which PR it was! If you believe this can be ignored for now / chrome is where most people use NC, I can go ahead and submit an approval
4 tasks
Merged
4 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

After #43090
The root changed
server/apps/files/src/components/FileEntry.vue
Lines 402 to 407 in 1b0eb2b