enh(metadata): store current file etag#42707
Merged
ArtificialOwl merged 1 commit intomasterfrom Mar 11, 2024
Merged
Conversation
6f7dc9d to
88855af
Compare
88855af to
fbcfa23
Compare
87b0f57 to
c60a6ca
Compare
c60a6ca to
4c4ff75
Compare
artonge
reviewed
Feb 29, 2024
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
4c4ff75 to
3fa5e59
Compare
artonge
approved these changes
Mar 7, 2024
susnux
approved these changes
Mar 11, 2024
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a way to verify if a metadata is up-to-date
This is done by storing the current file etag when setting a new value for a metadata:
When called, the method
isUpToDate($metadataKey)will compare current file etag with the one stored aside the metadata(while not mandatory, can be backported to 28)