fix(cron): Respect config_is_read_only config in in cron and console commands#42449
Closed
helmo wants to merge 2 commits intonextcloud:masterfrom
Closed
fix(cron): Respect config_is_read_only config in in cron and console commands#42449helmo wants to merge 2 commits intonextcloud:masterfrom
helmo wants to merge 2 commits intonextcloud:masterfrom
Conversation
Signed-off-by: Herman van Rink <[email protected]>
15eab2f to
f473089
Compare
4 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I’d like to keep the config and application code read-only for the webserver as an extra security measure.
We have the
config_is_read_onlyconfig boolean for that, but still occ and cron complain about not being the config file owner.Even if they do have write access, which I think atleast cron should be able to do without.
Checklist