fix(files_external): add back js config files#42428
Merged
Conversation
Member
Author
|
/backport to stable28 |
8 tasks
emoral435
approved these changes
Dec 22, 2023
Contributor
emoral435
left a comment
There was a problem hiding this comment.
Okay, I see what happened! LGTM!
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
78ce2c7 to
74b4b4e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems I cleaned up too much in 38480fd
The settings still have their own legacy handlings
server/apps/files_external/lib/Lib/FrontendDefinitionTrait.php
Lines 75 to 89 in 9319bbb
server/apps/files_external/lib/Lib/Auth/OAuth1/OAuth1.php
Line 50 in 215aef3
server/apps/files_external/lib/Lib/Auth/OAuth2/OAuth2.php
Line 48 in 215aef3
server/apps/files_external/lib/Lib/Auth/PublicKey/RSA.php
Line 55 in 5e31ed4
Fix #42158