fix(ViewController): Properly handle non-existent fileIds (regression lead to 500 errors)#42427
Merged
fix(ViewController): Properly handle non-existent fileIds (regression lead to 500 errors)#42427
Conversation
Fixes #42418 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
icewind1991,
max-nextcloud and
skjnldsv
8 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
approved these changes
Dec 22, 2023
max-nextcloud
approved these changes
Dec 28, 2023
Member
|
/backport to stable28 |
9 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The handling added in #40515 broke the handling for
fileIdsthat don't exist anywhere.Notes
One difference in behavior remains (versus <NC28) and that is that when we redirect to the
index, the URL in the browser used to drop the bogus fileId (but now it stays). I'd personally would prefer to drop it. I haven't deciphered all the changes to the newerfilesto know where that's coming from. I tried using the old RedirectResponse approach taken in NC27 (see here) and the bogus fileId still sticks around now. Open to suggestions and/or ignoring it since it may be outside the scope of this PR.Backport only to v28