Refresh FileList on current folder update#42382
Merged
Conversation
skjnldsv
reviewed
Dec 20, 2023
Member
|
/backport to stable28 |
Contributor
Author
|
/compile |
b88cf8f to
9cc8c68
Compare
skjnldsv
approved these changes
Dec 21, 2023
Contributor
|
This PR won't work because the function names mismatch: subscribe() uses "onUpdateNode", but actual name is "onUpdatedNode". |
1d5617e to
b3bf1cf
Compare
Contributor
Author
|
Nice catch @hschletz! I have now fixed it and tested again using my app which already integrates the changes: https://github.com/Raudius/files_scripts/blob/master/src/files.ts#L10 |
artonge
reviewed
Jan 11, 2024
artonge
approved these changes
Jan 11, 2024
Contributor
|
@Raudius please rebase and compile again, then it will be good to merge :) |
Signed-off-by: Raul Ferreira <r.ferreira.fuentes@gmail.com>
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com> Signed-off-by: Raul Ferreira Fuentes <Raudius@users.noreply.github.com>
75d22dc to
bced164
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: Raul Ferreira <r.ferreira.fuentes@gmail.com>
bced164 to
cf415bf
Compare
|
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR subscribes the
FileListview to the file-updated event. If the file updated matches the current folder it re-fetches the current view.Checklist